Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a "figure mode" button #753

Open
fedarko opened this issue Feb 1, 2020 · 2 comments · May be fixed by #767
Open

Adding a "figure mode" button #753

fedarko opened this issue Feb 1, 2020 · 2 comments · May be fixed by #767

Comments

@fedarko
Copy link
Contributor

fedarko commented Feb 1, 2020

This would be a single button accessible in the UI that does the following things:

  • changes the plot to 2D
  • changes the background to white
  • changes sample shapes to 2D circles (2d sample glyphs for 2d mode #604)
  • ideally, would move axis labels off of the actual axes (this might be worth a separate issue)

Eventually I'd like to take a shot at this, but don't really have time right now... I think this would make a lot of people happy.

(Came up during discussion with some folks in the lab.)

@ElDeveloper
Copy link
Member

This sounds like a great idea! This reminds me of the concept of "themes" which would be very cool to support.

@fedarko
Copy link
Contributor Author

fedarko commented Feb 1, 2020

Agreed that the "themes" idea is super cool -- once we'd have this functionality implemented, I imagine that passing in arbitrary settings for most of the options (e.g. making the plot be 3D and have a red background with all samples drawn as squares... that sounds awful, but you get the idea :) wouldn't be a ton of extra work.

That could also be useful as an easy way to add a "switch back to the starting configuration" button.

fedarko added a commit to fedarko/emperor that referenced this issue May 23, 2020
@fedarko fedarko linked a pull request May 30, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants