Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Graphical Artifacts In SVG + PNG Exports #736

Open
dhakim87 opened this issue Oct 1, 2019 · 5 comments
Open

Minor Graphical Artifacts In SVG + PNG Exports #736

dhakim87 opened this issue Oct 1, 2019 · 5 comments
Labels

Comments

@dhakim87
Copy link
Contributor

dhakim87 commented Oct 1, 2019

This issue was brought to my attention by Pedro.

Viewing either png or svg exports results in white lines (could potentially be background color lines) along the borders of each triangle. Further, both the svg and png exports are flat shaded rather than smooth shaded.

The lines visible on spheres (and also on all other shapes) correspond to the exact triangles being drawn by OpenGL underneath.

@dhakim87
Copy link
Contributor Author

dhakim87 commented Oct 1, 2019

Screen Shot 2019-10-01 at 12 34 43 PM

@dhakim87
Copy link
Contributor Author

dhakim87 commented Oct 1, 2019

Screen Shot 2019-10-01 at 12 36 30 PM

@dhakim87
Copy link
Contributor Author

dhakim87 commented Oct 1, 2019

Lines bordering the triangles appear to match background color.

@dhakim87
Copy link
Contributor Author

dhakim87 commented Oct 1, 2019

Users also don't understand why the red sphere is surrounded by a black halo when the background is white. That is the expected behavior of our current lighting parameters, but could potentially be addressed by setting our ambient lighting as a function of the background color.

@ElDeveloper
Copy link
Member

The problem stems from the SVGRenderer. This object draws each individual polygon, instead of say a whole geometry. This has many downsides, as you can tell. Perhaps we could re-write a version of the SVGRenderer that draws whole geometries instead of each polygon in the scene. Although it is still experimental, exporting as a vega document remediates several of these issues.

That is the expected behavior of our current lighting parameters, but could potentially be addressed by setting our ambient lighting as a function of the background color.

This is a great idea, I hadn't though about that. I would love to see how things look under different lightings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants