Update LCF_ChangeLog.md #337
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated change log inline with review group meeting from 9th April.
franciscave
requested changes
Jun 28, 2024
franciscave
requested changes
Jun 28, 2024
|
Apart from the requested changes in two lines, I think this is great. |
Feedback on line 23 from Francis. Consistent tense.
Pull request changes from Francis line 44. Consistent tense.
franciscave
approved these changes
Jun 29, 2024
Added the blank line requested by @franciscave
|
@franciscave I've added in the blank line on lines 32/33 as requested. |
|
@mdovey Could you review and (hopefully) approve please? The branch rules require two approvers before a merge is possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated change log inline with review group meeting from 9th April. #336