-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NetBox changes: Unit size for VirtualMachine.disk and VirtualDisk.size changed from 1 gigabyte to 1 megabyte. #413
Comments
Thank you. for this hint, will add a fix. |
Hey, I just pushed another commit to Thank you |
Hello, I've tried the last commit to development and it works correctly. Thank you. Reviewing the commit a doubt have raised. According to this netbox discussion, it seems that the preferred option to convert units is using SI (divide by 1000) The information provided by vmware uses the SI units (decimal) or are binary based? |
Hello @bb-Ricardo, While adding a new virtual disk, the size is entered in MB, but it is then displayed in GB (by dividing by 1000). FROM:
TO:
Merging the above with your modified version in development, it could be:
(Maybe there is a more elegant way to do that). |
Hi, I noticed this as well the next day. Just reading this: https://en.wikipedia.org/wiki/Byte#Multiple-byte_units makes you realise what happens if you led toner heads run your company. What a mess. Will try to fix it the next few days. |
Hello,
based on the recent changes in version 4.1.0 of NetBox regarding the unit size for VirtualMachine.disk and VirtualDisk.size (from 1 gigabyte to 1 megabyte), NetBox-sync reports an incorrect value in the virtual disk size of virtual machines.
The text was updated successfully, but these errors were encountered: