-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Numpy 2 Compatability #365
Conversation
Hello @bashtage! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-09-17 08:24:21 UTC |
@@ -221,17 +222,17 @@ | |||
data.append(int(line.split(",")[-1].strip(), 0)) | |||
return {"seed": seed, "data": np.array(data, dtype=cls.dtype)} | |||
|
|||
def setup_bitgenerator(self, seed, mode="legacy"): | |||
return self.bit_generator(*seed, mode=mode) | |||
def setup_bitgenerator(self, seed, mode="sequence"): |
Check notice
Code scanning / CodeQL
Mismatch between signature and use of an overridden method Note test
call
method TestPCG64XSLRR.setup_bitgenerator
Overridden method signature does not match
call
method TestPCG64XSLRR.setup_bitgenerator
Overridden method signature does not match
call
method TestPCG64XSLRR.setup_bitgenerator
Overridden method signature does not match
call
method TestPCG64XSLRR.setup_bitgenerator
Overridden method signature does not match
call
method TestPCG64XSLRR.setup_bitgenerator
Overridden method signature does not match
call
method TestPCG64DXSM.setup_bitgenerator
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #365 +/- ##
==========================================
- Coverage 92.93% 88.29% -4.64%
==========================================
Files 53 50 -3
Lines 8546 8277 -269
Branches 493 490 -3
==========================================
- Hits 7942 7308 -634
- Misses 572 937 +365
Partials 32 32 ☔ View full report in Codecov by Sentry. |
86395b8
to
19cf035
Compare
Work to make Randomgen build and work on NumPy 2