From 0b09ae264da0089383d1466bafc00c366f1d4205 Mon Sep 17 00:00:00 2001 From: delphiki Date: Mon, 13 Nov 2023 18:27:56 +0100 Subject: [PATCH 1/2] fix(attachments): use proper attribute to retrieve URLs --- pronotepy/dataClasses.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pronotepy/dataClasses.py b/pronotepy/dataClasses.py index 1cddbdc..9b3714a 100644 --- a/pronotepy/dataClasses.py +++ b/pronotepy/dataClasses.py @@ -761,7 +761,8 @@ def __init__(self, client: ClientBase, json_dict: dict) -> None: self.type: int = self._resolver(int, "G") # 0 link, 1 file if self.type == 0: - self.url = self.name + url: str | None = self._resolver(str, "url", default=None) + self.url = self.name if url is None else url else: padd = Padding.pad( json.dumps({"N": self.id, "Actif": True}).replace(" ", "").encode(), 16 From a56c3266f1daf7c7a5b1e9d4c467da40ac8eaec8 Mon Sep 17 00:00:00 2001 From: bain3 <31798786+bain3@users.noreply.github.com> Date: Sun, 19 Nov 2023 15:00:19 +0100 Subject: [PATCH 2/2] correct typing --- pronotepy/dataClasses.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pronotepy/dataClasses.py b/pronotepy/dataClasses.py index 9b3714a..7deba4b 100644 --- a/pronotepy/dataClasses.py +++ b/pronotepy/dataClasses.py @@ -761,8 +761,8 @@ def __init__(self, client: ClientBase, json_dict: dict) -> None: self.type: int = self._resolver(int, "G") # 0 link, 1 file if self.type == 0: - url: str | None = self._resolver(str, "url", default=None) - self.url = self.name if url is None else url + url = self._resolver(str, "url", default=None) + self.url: str = self.name if url is None else url else: padd = Padding.pad( json.dumps({"N": self.id, "Actif": True}).replace(" ", "").encode(), 16