Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

PEP 515: Underscores in numeric literals #221

Open
1 task done
redfast00 opened this issue Jan 16, 2018 · 5 comments · May be fixed by #334
Open
1 task done

PEP 515: Underscores in numeric literals #221

redfast00 opened this issue Jan 16, 2018 · 5 comments · May be fixed by #334
Assignees

Comments

@redfast00
Copy link

Prerequisites

Description

Numbers like 100_000_000 aren't properly highlighted (see PEP 515 specification). This should be pretty easy to fix, just edit these lines in the grammar. I tried to fix this myself, but wasn't able to get atom dev running.

Steps to Reproduce

  1. Put 10_000_000 in source code.

Expected behavior:
Proper highlighting

Actual behavior:
Number highlighting stops in the middle of the number

Reproduces how often:
100%

Versions

Atom    : 1.23.3
Electron: 1.6.15
Chrome  : 56.0.2924.87
Node    : 7.4.0
@50Wliu
Copy link
Contributor

50Wliu commented Jan 21, 2018

I tried to fix this myself, but wasn't able to get atom dev running.

Please ping me in the Slack channel or on Discuss and I'll help you out. I'm @Wliu on both.

@Alexey-T
Copy link

Alexey-T commented Oct 1, 2019

Why isn’t it fixed yet? Easy to do

@kac487
Copy link

kac487 commented Sep 7, 2021

Are there any updates on this one?

@50Wliu 50Wliu self-assigned this Sep 14, 2021
@50Wliu
Copy link
Contributor

50Wliu commented Sep 14, 2021

@kac487 do you know if this is happening with the Tree Sitter grammar, or just the non-Tree Sitter one? (If you don't know, that's fine)

@kac487
Copy link

kac487 commented Sep 18, 2021

Sorry, I don't know which one it is.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants