Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Nmea0183Helper.GetPrnFromNmeaSatId method is incorrect, the constellation retrieved based on the satellite ID is incorrect. #17

Open
Anonymy opened this issue Jun 22, 2024 · 2 comments
Open

The Nmea0183Helper.GetPrnFromNmeaSatId method is incorrect, the constellation retrieved based on the satellite ID is incorrect. #17

Anonymy opened this issue Jun 22, 2024 · 2 comments
Assignees
@asvol @malobanov
Labels
bug Something isn't working

Comments

@Anonymy
Copy link

Anonymy commented Jun 22, 2024

The Nmea0183Helper.GetPrnFromNmeaSatId method is incorrect, the constellation retrieved based on the satellite ID is incorrect.
$GBRMC,075907.515,A,3137.022779,N,11957.754034,E,0.00,000.00,120624,,,A,U0E
$GBGSV,4,1,13,11,73,206,42,42,69,339,42,43,65,281,42,38,59,356,41,17A
$GBGSV,4,2,13,14,56,276,40,03,53,201,33,08,52,339,38,34,50,172,31,17C
$GBGSV,4,3,13,13,48,321,37,60,33,240,32,33,32,256,35,21,11,224,32,178
$GBGSV,4,4,13,28,,,35,178
$GBGSV,1,1,03,42,69,339,40,43,65,281,38,38,59,356,38,34B
@asv-soft-u01
Copy link
Contributor

Thanks for your report! We are currently working on resolving this issue.

malobanov added a commit that referenced this issue Sep 9, 2024
@malobanov
bugfix(nmea): fix the method that returns the satellite number and co…
9b5290f 
…nstellation. Add unit test

Issue #17: #17
Asana: https://app.asana.com/0/1203851531040615/1208116466425061/f
malobanov added a commit that referenced this issue Sep 10, 2024
@malobanov
bugfix(nmea): add case for SBAS sat numbers
f158da8 
github: #17
@asvol asvol added the bug Something isn't working label Sep 10, 2024
@asvol
Copy link
Collaborator

asvol commented Sep 10, 2024

@Anonymy Please check and close the issue if everything is resolved. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asvol asvol

@malobanov malobanov

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@asvol @Anonymy @malobanov @asv-soft-u01