Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0.x] NO-ISSUE: Fix drools version for nightly.quarkus-platform #1229

Open
wants to merge 2 commits into
base: 10.0.x
Choose a base branch
from

Conversation

tkobayas
Copy link

Review by @pibizza "[REVIEW] [NOT OK] Current status for the kogito 10.x jobs"

Red
- quarkus-platform.deploy
The build is consistently failing with the error "ERROR: Couldn't find any
revision to build. Verify the repository and branch configuration for this
job."
https://ci-builds.apache.org/job/KIE/job/kogito/job/10.0.x/job/nightly/job/quarkus-platform.deploy/9/
09:28:40  [INFO] Resolving Repository https://github.com/apache/incubator-kie-drools:17.0.x. CredentialsID: kie-ci

It tries to check out branch 17.0.x.

getTargetBranch(7) means adds the major version 7, which is probably an old approach when kogito version was 1 and drools version was 8. Now, all projects aligns to 10.0.x.

@tkobayas tkobayas changed the title NO-ISSUE: Fix drools version for nightly.quarkus-platform [10.0.x] NO-ISSUE: Fix drools version for nightly.quarkus-platform Jul 25, 2024
@tkobayas
Copy link
Author

tkobayas commented Jul 25, 2024

Note: Need to forward port this to main, too.
-> for main #1230

@tkobayas
Copy link
Author

Same for optaplanner branch.

Copy link
Contributor

@pibizza pibizza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jstastny-cz
Copy link
Contributor

I'd check one thing here with the mailing list - if we still want to perform any steps towards being part of that platform. I mean, fixing pipelines is a good thing here, but I am not sure if we actually want to make it work.

@tkobayas
Copy link
Author

tkobayas commented Aug 6, 2024

I'd check one thing here with the mailing list - if we still want to perform any steps towards being part of that platform. I mean, fixing pipelines is a good thing here, but I am not sure if we actually want to make it work.

Hi @jstastny-cz , sorry, I'm not clear about it. Could you raise it to the mailing list?

Sent to dev ML [DISCUSS] Shall we keep fixing kogito-pipelines issues?

Sent to dev ML [DISCUSS] keep kogito as a part of quarkus-platform?

Copy link
Contributor

@mareknovotny mareknovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this was for legacy layout of branches/versions

@mareknovotny
Copy link
Contributor

just adding a link to the ML discussion thread https://lists.apache.org/thread/kzjw1o6rv58gd74mzzr11v6ymzw7khsb

@tkobayas
Copy link
Author

https://lists.apache.org/thread/kzjw1o6rv58gd74mzzr11v6ymzw7khsb

The dev ML thread is still on-going. But at least, we are on the same page that this discussion shouldn't block 10.0 release. So we don't need to pass this nightly.quarkus-platform job at the moment. We can keep this PR on-hold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants