Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attrs for line arrows are taken from the parent line instead of the arrow object #1335

Open
ensconced opened this issue May 5, 2023 · 0 comments

Comments

@ensconced
Copy link

ensconced commented May 5, 2023

I tried using the form at https://antv-issue-helper.surge.sh but it was not working.

This issue is in @antv/g-svg 0.5.6. I know this is an old version, but I would like to open a PR to fix it. If I do so, would it be possible to release a version 0.5.7? This bug is affecting @antv/g6, which currently depends on "@antv/g-svg": "^0.5.1", (in the @antv/g6-pc package.) If we can release a 0.5.7 to fix this, I would then open a PR to upgrade @antv/g6 to use 0.5.7.

Here is an example of the issue:
https://codesandbox.io/s/wild-rain-mhgy08?file=/src/index.js:0-431

The arrow should have a blue fill and green stroke, but instead it uses the stroke and fill from the parent line shape.

Result when using @antv/g-svg:

Screenshot 2023-05-05 at 16 33 36

Expected result (this is using @antv/g-canvas, although I had to edit the path of the arrow slightly to get the same shape):

Screenshot 2023-05-05 at 16 33 41

Would you accept a PR from me to fix this?


Chrome 112.0.5615.137 (Official Build) (arm64)
macOS 13.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant