From 0e0bc4bd34c3ed4d916c7dfa2579c6437a473684 Mon Sep 17 00:00:00 2001 From: Anton Lukin Date: Sun, 28 Jul 2024 11:04:42 +0200 Subject: [PATCH] fix wpcs linter warnings --- classes/class-core.php | 2 +- networks/class-network-make.php | 31 ++++++++++++------------------- readme.txt | 2 +- 3 files changed, 14 insertions(+), 21 deletions(-) diff --git a/classes/class-core.php b/classes/class-core.php index 7c1bd30..99d7264 100644 --- a/classes/class-core.php +++ b/classes/class-core.php @@ -54,7 +54,7 @@ public static function init_networks() { 'Social_Planner\Network_Facebook' => SOCIAL_PLANNER_DIR . '/networks/class-network-facebook.php', 'Social_Planner\Network_OK' => SOCIAL_PLANNER_DIR . '/networks/class-network-ok.php', 'Social_Planner\Network_Linkedin' => SOCIAL_PLANNER_DIR . '/networks/class-network-linkedin.php', - 'Social_Planner\Network_Make' => SOCIAL_PLANNER_DIR . '/networks/class-network-make.php', + 'Social_Planner\Network_Make' => SOCIAL_PLANNER_DIR . '/networks/class-network-make.php', ); /** diff --git a/networks/class-network-make.php b/networks/class-network-make.php index d96d3ad..dcbbc70 100644 --- a/networks/class-network-make.php +++ b/networks/class-network-make.php @@ -68,7 +68,7 @@ public static function get_fields() { 'required' => true, ), - 'title' => array( + 'title' => array( 'label' => __( 'Subtitle', 'social-planner' ), 'hint' => __( 'Optional field. Used as an subtitle if there are multiple Make providers.', 'social-planner' ), ), @@ -88,14 +88,13 @@ public static function send_message( $message, $settings ) { return new WP_Error( 'sending', esc_html__( 'WebHook URL parameter is not found', 'social-planner' ) ); } - $response = self::make_request( $message, $settings['webhook_url'] ); - if($response["response"]["code"] == 200) { + if ( 200 === $response['response']['code'] ) { return true; } - return new WP_Error( 'sending', esc_html__( 'API return error: ', 'social-planner' ).$response->code ); + return new WP_Error( 'sending', esc_html__( 'API return error: ', 'social-planner' ) . $response->code ); } /** @@ -104,7 +103,7 @@ public static function send_message( $message, $settings ) { * @param array $message List of message args. */ private static function prepare_message_excerpt( $message ) { - $excerpt = ""; + $excerpt = ''; if ( ! empty( $message['excerpt'] ) ) { $excerpt = $message['excerpt']; @@ -123,25 +122,23 @@ private static function prepare_message_excerpt( $message ) { /** * Prepare data and send request to remote API. * - * @param array $message Message data. - * @param string $path Remote API URL path. - * @param string $token Access token from settings. + * @param array $message Message data. + * @param string $webhook_url Remote API URL. */ protected static function make_request( $message, $webhook_url ) { $body = array(); - - $url = $webhook_url; + + $url = $webhook_url; $excerpt = self::prepare_message_excerpt( $message ); - - if ( empty( $excerpt ) && empty( $message['poster_id']) ) { + + if ( empty( $excerpt ) && empty( $message['poster_id'] ) ) { return new WP_Error( 'sending', esc_html__( 'Excerpt and poster are both empty', 'social-planner' ) ); } if ( ! empty( $message['poster_id'] ) ) { - $body["image_url"] = wp_get_attachment_url($message['poster_id']); + $body['image_url'] = wp_get_attachment_url( $message['poster_id'] ); } - $body['content'] = $excerpt; /** @@ -169,17 +166,13 @@ protected static function make_request( $message, $webhook_url ) { private static function send_request( $url, $body, $headers = null ) { $args = array( 'user-agent' => 'social-planner/' . SOCIAL_PLANNER_VERSION, - 'body' => $body, + 'body' => $body, ); - // array_merge($args, $body); - if ( $headers ) { $args['headers'] = $headers; } - - /** * Filter request arguments right before sending. * diff --git a/readme.txt b/readme.txt index 91f55bb..7607ed7 100644 --- a/readme.txt +++ b/readme.txt @@ -52,7 +52,7 @@ If you find a bug or want to add new feature to this plugin, create new [issue]( == Changelog == = 1.4.0 = -* Adding new provider for make. +* Adding new provider for make.com. = 1.3.2 = * Bump 'Tested up' version and update readme