Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trait CacheableRepository - getCacheMinutes method was removed without breaking version? #763

Open
coelsman opened this issue Oct 18, 2021 · 1 comment

Comments

@coelsman
Copy link

coelsman commented Oct 18, 2021

From version 2.7.7 to 2.7.9, method getCacheMinutes had been replaced by getCacheTime.
As I investigated, the origin PR (#762) was marked as breaking changes, the released version must be 2.8 or whatever like that.

Follow new changes, I suggest:

  • Keep origin getCacheMinutes method.
  • Write new method called getCacheSeconds.
  • Method getCacheTime: handle difference of ttl between Laravel version and call correspond method above.
@bsormagec
Copy link
Collaborator

I am open to PR about this @coelsman :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants