-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bson implementation #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial implementation of encapsulate for bson module. Unit test created as well. Signed-off-by: Kevin Liu <kevin.liu@csu.fullerton.edu>
The encapsulate function was rewritten in order to have the correct parameters and return type. Signed-off-by: Kevin Liu <kevin.liu@csu.fullerton.edu>
The reveal function was implemented. It takes a byte vector and returns a Result<PacketVersion, std::io::Error>. Signed-off-by: Kevin Liu <kevin.liu@csu.fullerton.edu>
Remade the acc structure. This is because the previous structure did not do well with serialization into bson. Signed-off-by: Kevin Liu <kevin.liu@csu.fullerton.edu>
rewrote the reveal function in order to function properly with the new bson implementation. Signed-off-by: Kevin<kevin.liu@csu.fullerton.edu>
formatted code Signed-off-by: Kevin<kevin.liu@csu.fullerton.edu>
amyipdev
reviewed
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks pretty good - have a few questions but no changes requested so far, almost ready to merge
Signed-off-by: Amy Parker <amy@amyip.net>
amyipdev
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of encapsulate and reveal functions in the bson module, as well as a single unit test.