From e4afb06311f819a6a39bf964cd57cc2454e2bae4 Mon Sep 17 00:00:00 2001 From: Adam Mitchell Date: Mon, 30 Sep 2024 14:03:32 +0100 Subject: [PATCH] Fix test --- app/config.py | 4 ++-- tests/app/reports/test_rest.py | 26 ++++++-------------------- 2 files changed, 8 insertions(+), 22 deletions(-) diff --git a/app/config.py b/app/config.py index 2114b3e99..62b5a2bf2 100644 --- a/app/config.py +++ b/app/config.py @@ -290,8 +290,6 @@ class Config(object): EAS_EMAIL_REPLY_TO_ID = "591164ac-721d-46e5-b329-fe40f5253241" - REPORTS_SLACK_WEBHOOK_URL = "" - # as defined in api db migration 0331_add_broadcast_org.py BROADCAST_ORGANISATION_ID = "38e4bf69-93b0-445d-acee-53ea53fe02df" @@ -398,6 +396,8 @@ class Test(Config): ) ADMIN_EXTERNAL_URL = f"https://{TENANT}admin.{SUBDOMAIN}emergency-alerts.service.gov.uk" + REPORTS_SLACK_WEBHOOK_URL = "https://hooks.slack.com/somewhere" + CBC_PROXY_ENABLED = True DVLA_EMAIL_ADDRESSES = ["success@simulator.amazonses.com", "success+2@simulator.amazonses.com"] diff --git a/tests/app/reports/test_rest.py b/tests/app/reports/test_rest.py index 37affa076..b64ac5856 100644 --- a/tests/app/reports/test_rest.py +++ b/tests/app/reports/test_rest.py @@ -1,6 +1,3 @@ -from emergency_alerts_utils.clients.slack.slack_client import SlackMessage - - def test_create_report(admin_request, mocker): data = { "type": "some-violation", @@ -9,23 +6,12 @@ def test_create_report(admin_request, mocker): "body": {"something": "random", "could_be": "anything"}, } - mock_send_message_to_slack = mocker.patch( - "app.slack_client.send_message_to_slack", + mock_log_report = mocker.patch( + "app.reports.rest.slack_client.send_message_to_slack", autospec=True, + return_value={"message": "Slack message sent to the provided webhook URL."}, ) - slack_message = SlackMessage( - webhook_url="", - subject="Reporting Endpoint Submission", - message_type="info", - markdown_sections=[ - ( - "*Type*: some-violation\n\n" - "*URL*: https://gov.uk\n\n" - "*User Agent*: some-browser\n\n" - '*Body*: ```{"something":"random","could_be":"anything"}```' - ) - ], - ) - admin_request.post("reports.log_report", _data=data) - mock_send_message_to_slack.assert_called_once_with(slack_message) + admin_request.post("reports.log_report", _data=data, _expected_status=201) + + mock_log_report.assert_called_once()