Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move security group creation to Pulumi #2160

Draft
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

jemrobinson
Copy link
Member

@jemrobinson jemrobinson commented Aug 28, 2024

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

n/a

⤴️ Summary

  • Create a Pulumi application during SHM deployment with permissions to edit groups
  • Use this application (and service principal) to initialise the pulumi-azuread provider
    • create Entra groups

🌂 Related issues

Closes #2158

🔬 Tests

Tested on a new SRE deployment

@jemrobinson jemrobinson force-pushed the 2158-move-security-group-creation-to-pulumi branch from a7c274d to 7d63b8f Compare August 28, 2024 13:50
Copy link

github-actions bot commented Aug 28, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  data_safe_haven/commands
  sre.py 89-90, 93-94
  data_safe_haven/config
  context.py 43-51, 56-57
  shm_config.py
  sre_config.py
  data_safe_haven/external/api
  azure_sdk.py 475, 1300-1316
  graph_api.py 1054
  data_safe_haven/infrastructure
  project_manager.py
  data_safe_haven/infrastructure/programs
  declarative_sre.py 113
  imperative_shm.py 118, 147-167
  data_safe_haven/infrastructure/programs/sre
  entra.py 18, 30-33
  data_safe_haven/provisioning
  sre_provisioning_manager.py
Project Total  

This report was generated by python-coverage-comment-action

@jemrobinson jemrobinson force-pushed the 2158-move-security-group-creation-to-pulumi branch from 7a21be5 to 7e88e72 Compare September 27, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Entra security groups with Pulumi
2 participants