Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.5.1 installs stray top-level tests package #161

Closed
mgorny opened this issue Jul 23, 2024 · 2 comments
Closed

1.5.1 installs stray top-level tests package #161

mgorny opened this issue Jul 23, 2024 · 2 comments

Comments

@mgorny
Copy link
Contributor

mgorny commented Jul 23, 2024

The new release installs a stray top-level tests package, i.e.:

/usr/lib/python3.12/site-packages/tests/__init__.py
/usr/lib/python3.12/site-packages/tests/conftest.py
/usr/lib/python3.12/site-packages/tests/example_script.py
...
@EarthenSky
Copy link

EarthenSky commented Jul 23, 2024 •
edited
Loading

This is a breaking change for any projects which use their own top-level tests package

mgorny added a commit to mgorny/pytest-subprocess that referenced this issue Jul 24, 2024
@mgorny
Revert "Add tests directory to the testdir. (aklajnert#128)"
bfea58c 
This reverts commit 1855824.
The solution used there is incorrect and results in `tests` being
installed to site-packages.

Fixes aklajnert#161
@mgorny
Copy link
Contributor Author

mgorny commented Jul 24, 2024

This is a regression introduced in 1855824. Filed #162 to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mgorny @EarthenSky