Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pre-commit for running linters #67

Closed
Arfey opened this issue Jan 11, 2019 · 6 comments
Closed

Added pre-commit for running linters #67

Arfey opened this issue Jan 11, 2019 · 6 comments
Labels
enhancement New feature or request

Comments

@Arfey
Copy link
Member

Arfey commented Jan 11, 2019

This is good feature but we running all linters from docker and it's not fast. Does anyone have any thoughts about this?

@aio-libs-bot

This comment has been minimized.

@aio-libs-bot aio-libs-bot added the enhancement New feature or request label Jan 11, 2019
@webknjaz
Copy link
Member

What do you mean? Run it in the CI directly

@Arfey
Copy link
Member Author

Arfey commented Jan 11, 2019

CI as a solution. Thanks :) I will add ci file for gitlab.

@Arfey
Copy link
Member Author

Arfey commented Jan 13, 2019

I think that i have better idea. Right now all linters and static checker work with docker. It's works like that because i wonted that user after run create-ago-app don't install any additional packages. But, we can add mypy, flake8 and other packages in create-aio-packages to requirement packages in setup.py.

@CatCanCreate
Copy link
Contributor

CatCanCreate commented Jan 31, 2019

Add into .git/hooks/pre-commit:

#!/bin/sh
flake8 src/

After

chmod +x .git/hooks/pre-commit

For example?)

@webknjaz
Copy link
Member

webknjaz commented Feb 1, 2019

there's a tool which makes it more generic: https://pre-commit.com/

@Arfey Arfey closed this as completed Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants