Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greedy query planning. #1442

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

joka921
Copy link
Member

@joka921 joka921 commented Aug 14, 2024

It is currently enabled by an explicit Runtime parameter.

It is currently enabled by an explicit Runtime parameter.
Copy link

sonarcloud bot commented Aug 14, 2024

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 32.00000% with 34 lines in your changes missing coverage. Please review.

Project coverage is 89.57%. Comparing base (0b9d26f) to head (2b8b261).
Report is 3 commits behind head on master.

Files Patch % Lines
src/engine/QueryPlanner.cpp 29.16% 33 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1442      +/-   ##
==========================================
- Coverage   89.66%   89.57%   -0.09%     
==========================================
  Files         345      345              
  Lines       29947    29988      +41     
  Branches     3306     3308       +2     
==========================================
+ Hits        26851    26861      +10     
- Misses       1954     1987      +33     
+ Partials     1142     1140       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a first look with Johannes. Awesome that this was possible with so little code. Speaks for the quality of the question planner code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants