Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile to Ubuntu 22.04 + integrate qlever script #1439

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Aug 12, 2024

  1. Update Dockerfile to Ubuntu 22.04 + integrate qlever script

    The old Dockerfile called `ServerMain` directly using a small selection
    of environment variables with outdated names. It was also outdated in
    other respects.
    
    The new Dockerfile installs the `qlever` script, so that it can be
    called from inside the container.
    
    Remaining questions / TODOs, feedback welcome:
    
    1. Right now, the script is installed as part of the docker build via
       `pipx install qlever`. Is this the right way to do it?
       Alternatives would be to clone the GitHub repo and `pipx install -e
       .` from there, or include the the GitHub repo as a submodule of this
       repository.
    
    2. How do we handle the QLever UI. We could just call `qlever ui` from
       inside the container. But that would pull the Docker image for the
       Qlever UI and run a Docker container inside of a Docker container.
       It's possible, but not the right way to do it. If both are needed,
       the container for the QLever engine and the contaner for the QLever
       UI should run side by side.
    
    3. The`qlever setup-config` command should have options that overwrite
       the variables in the produced Qleverfile. In particular, there should
       be an option for setting `SYSTEM = native`. Otherwise it has to be
       stated explictly for each command, where that is relevant (in
       particular: `qlever index`, `qlever start`, `qlever
       example-queries`).
    Hannah Bast committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    421a16c View commit details
    Browse the repository at this point in the history
  2. Replace as by AS (three times)

    Hannah Bast committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    471d2d1 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Use ENV=... instead of ENV ... everywhere

    Hannah Bast committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    fabb137 View commit details
    Browse the repository at this point in the history