Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination for the products at shopify #5

Open
abdulhannanali opened this issue Feb 6, 2017 · 3 comments
Open

Add pagination for the products at shopify #5

abdulhannanali opened this issue Feb 6, 2017 · 3 comments
Assignees

Comments

@abdulhannanali
Copy link
Owner

Shopify is quite limited by the range of products it displays at first, the pagination is necessary in order to display a full range of products we have there in our collection or the complete catalog. By default, it's going to display only the 12 or 13 most recent ones.

One hurdle we face here in order to manage pagination is the structure we need to maintain for it in the state and if there are any changes we are going to make for this structure.

@abdulhannanali abdulhannanali self-assigned this Feb 6, 2017
@abdulhannanali
Copy link
Owner Author

The data structure range changes can range from just a small change to append the products there are to keep the page number within the state too.
The effort we are going to put here in order to make this functionality available makes some rethinking as this is going to be a substantial effort.

@abdulhannanali
Copy link
Owner Author

There needs to be some prefetching we need to do here in order to determinate if we can paginate to the next page or not. As the response returned by the Shopify Buy SDK doesn't make us aware of any information regarding this problem. One other thing we can do here is probably writing our own SDK Wrapper, but that would kill the whole purpose of doing this effort.

@abdulhannanali
Copy link
Owner Author

Adding pagination is important, as it allows us to test a lot of the functionality, but the way we have designed the functionality right now. It doesn't seem the structure is in it's best shape to allow a feature like this to exist in the current shape.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant