Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov coverage data seems outdated #755

Closed
BobLd opened this issue Jan 14, 2024 · 5 comments
Closed

Codecov coverage data seems outdated #755

BobLd opened this issue Jan 14, 2024 · 5 comments

Comments

@BobLd
Copy link
Collaborator

BobLd commented Jan 14, 2024

It seems that the code coverage numbers available on https://app.codecov.io/gh/UglyToad/PdfPig are outdate, as the latest commit available is as of 2 years ago:
image

Also, the Codecov NuGet package is deprecated:
image

@EliotJones do you remember how it is supposed to work? How is the codecov updated? Is it thourg a GitHub Action? Happy to look into that but I'd rather have some direction first

@EliotJones
Copy link
Member

I don't remember to be honest, I think it probably was in the build action. I'm in favour of removing it really. I think integration tests provide a lot more value than the unit tests in most instances so I'm not too concerned about raw coverage %

@BobLd
Copy link
Collaborator Author

BobLd commented Jan 14, 2024

I agree, will try to find time to take care of that

@Numpsy
Copy link
Contributor

Numpsy commented Feb 6, 2024

Was just having a look at the deps after seeing #771 - if there is no interest in the coverage, would there be interest in a PR of Numpsy@f1c3161 or something to remove the dependencies?

@Numpsy Numpsy mentioned this issue Feb 6, 2024
@BobLd
Copy link
Collaborator Author

BobLd commented Feb 6, 2024

@Numpsy yes definitely! Feel free to open a PR, I'll review it shortly

@BobLd
Copy link
Collaborator Author

BobLd commented Feb 8, 2024

Fixed with #773

@BobLd BobLd closed this as completed Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants