-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar resizer 2: resize your sidebar by dragging #8637
base: master
Are you sure you want to change the base?
Conversation
Run & review this pull request in StackBlitz Codeflow. |
Confirmed: BurningTreeC has already signed the Contributor License Agreement (see contributing.md) |
Ok, I've seen that this PR has some issues I forgot fixing 😁 |
@Jermolene @pmario this is now ready to have a look at |
@BurningTreeC |
Hi @kookma this is the grip to drag, it shows visually where we can drag something, it's fully intentional. |
Or, @kookma , do you mean the invisible gap between the story river and the sidebar? It's 22px wide ... I believe I can change that so that there's no gap but I'm not that sure |
Okay, this is by design! I think it is fine now! |
This PR is a follow-up to #8627
In comparison to the previous PR the resizer has moved a bit more versus the story river.
That's why here the eventcatcher divs are placed within the
tc-story-river
which in my opinion is the best way to do this.Therefor I needed to make space between the story-river and the sidebar so that the sidebar doesn't hide the sidebar-resizer. I took 22px from the sidebar width (by also removing 22px from its
padding-left
- so you don't see this change).Please test this PR 🙂
What's not handled at the moment is the
story-right
setting.I'm not sure what it should do in this setting. But I have the options to integrate it.
Do you also think it's better doing it this way?