mws authentication #8596
mws authentication #8596
Conversation
|
|
|
Confirmed: webplusai has already signed the Contributor License Agreement (see contributing.md) |
|
Thank you @webplusai this is looking good. I will provide some detailed feedback shortly. |
|
Following along (very busy at work atm, company is reorging... again). This is exciting stuff! |
There was a problem hiding this comment.
Thank you @webplusai this is looking good. There is what looks like some work-in-progress areas such as handleLogin. It makes a lot of sense to keep things simple there temporarily, and so I would like to merge this. However I think it may just be worth you adding comments to tag the TODO areas to make explicit the areas that we need to revisit.
| <body> | ||
| <div class="login-container"> | ||
| <h1>TiddlyWiki Login</h1> | ||
| <$set name="returnUrl" value={{{ [{$:/temp/mws/login/returnUrl}!is[blank]else{$:/info/url/query}split[returnUrl=]last[]else[/]] }}}> |
There was a problem hiding this comment.
Is $:/temp/mws/login/returnUrl intended as a debugging aid?
| @@ -0,0 +1,9 @@ | |||
| { | |||
| "title": "$:/plugins/tiddlywiki/authentication", | |||
There was a problem hiding this comment.
The tests are failing on my machine because of this error:
Failures:
1) Plugin tests every plugin should have the required standard fields plugin $:/plugins/tiddlywiki/authentication should have name, description and list fields
This can be fixed by adding to the plugin.info file (the fields ordering should match that of the main multiwikiserver plugin):
"name": "Multi Wiki Server Authentication",
"stability": "STABILITY_1_EXPERIMENTAL"
But in fact I do not think that we should introduce an additional plugin. The login page and any associated components can be packaged as part of the main MWS plugin under the namespace $:/plugins/multiwikiserver/auth/form/login.
Then we should break the form into subsidiary tiddlers that are transcluded by the login page. Users can then override those tiddlers to add their own heading/graphics etc.
No description provided.