Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue during make - CINT required #21

Open
taylorjtamu opened this issue Apr 5, 2019 · 1 comment
Open

Issue during make - CINT required #21

taylorjtamu opened this issue Apr 5, 2019 · 1 comment

Comments

@taylorjtamu
Copy link

I ran into the same issue as reported at this link while building SVE for a researcher here:
#2

I've dug into it some to understand what's happening and why. It appears that Speedseq pulls in its own version of CNVnator which includes a call for -lCint in its included CNVnator version's Makefile. This means that even though SVE is pulling in a version of CNVnator without this library requirement, Speedseq still is looking for it.
Speedseq specifies a requirement of ROOT version 5.34.20 but SVE does not, even though that is causing the build to fail.

Per the prior issue, you can get around this by removing the -lCint flag in SVE/src/speedseq/src/cnvnator/Makefile
I've put this into an install script as:
sed -i '0,/-lCint /{s/-lCint //}' SVE/src/speedseq/src/cnvnator/Makefile
(obviously adjust the directory to account for where SVE is installed)

I see three reasonable and possible approaches to this issue:

  1. Either have the -lCint flag removed from the makefile under SVE/src/speedseq/src/cnvnator in source or make clear in install instructions that it's a required step.
  2. Specify that ROOT 5.34.20 is required for the installation, if the newer version of CNVnator that SVE is using can compile against that version.
  3. Have Speedseq update to a newer version of CNVnator, or adjust their Makefile if they already have. I will probably be posting an issue with them as well to see if anything will be done, but I don't have much hope given the age of many of their outstanding issues and that they specifically require the version of ROOT that will work with their code.

I do understand that this is just as much if not more an issue with Speedseq, but SVE appears to be the more actively maintained project with more potential for a response, even if that's just adding specificity to the requirements.

@lslochov
Copy link

Hi @taylorjtamu, thanks for bringing this to our attention. We are planning a number of upgrades for SVE and FusorSV, which include resolving issues such as this to make the overall codebase more robust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants