From 7fa68312ce4cce34bb1b91f083f44eb05245e512 Mon Sep 17 00:00:00 2001 From: "Peter A. Jonsson" Date: Tue, 24 Sep 2024 13:05:02 +0200 Subject: [PATCH] CONTRIBUTING.md: fix broken link The Cesium guide has moved, so update the URL. Also strengthen the phrasing about following the convention by dropping the word "can". --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 0f541f7cb5e..4b93711ae78 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -40,7 +40,7 @@ Please get involved in code review. It's a great way to expand your knowledge of - Verify the code builds successfully and there are no lint warnings (run `gulp`). - Check basic functionality of the map, such as enabling data sources in both 2D and 3D. - Verify that all specs pass. If anything you did might be browser-dependent, you should run the specs in all the major supported browsers. -- Review the code itself for quality of implementation and consistency with coding conventions. Until we have our own coding conventions, we can [use Cesium's](https://github.com/AnalyticalGraphicsInc/cesium/wiki/JavaScript-Coding-Conventions). +- Review the code itself for quality of implementation and consistency with coding conventions. Until we have our own coding conventions, we use [Cesium's](https://github.com/CesiumGS/cesium/blob/master/Documentation/Contributors/CodingGuide/README.md). Reviewers are welcome to make minor edits to a pull request (e.g. fixing typos) before merging it. If a reviewer makes larger changes, someone else - maybe the original author of the pull request - should take a look at the changes before the entire pull request is merged.