You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that both tendrl-ceph-integration and tendrl-gluster-integration are referenced in README file of node agent, without further explanation what to do with these components (besides default configuration).
Based on the already reported issues related to this:
I would assume that content of the README file belongs to installation.rst file (as suggested in #89) and that documentation for overall high level installation of Tendrl belongs to Tendrl/documentation repo (as suggested in Tendrl/specifications#25). Another evidence suggesting that this is the case is the fact that no interesting details or further reasoning about integration of node-agent and ceph/gluster-integration components are given (right now, it's just clone a repo and copy default config file).
That said, I may be wrong and there may be some reason to reference other components in installation.rst file. If this is the case, this issue is tracking the work on documenting the reasoning of this better, otherwise we could just drop the references to tendrl-ceph-integration and tendrl-gluster-integration from installation.rst file during work on the issues I referenced above and this issue can be closed.
The text was updated successfully, but these errors were encountered:
Yes you are right!, Node agent is not depends on gluster-integration or ceph-integration. So all the references and configuration related to any of those packages should be removed from node-agent installation or readme files.
Only node-agent is required for gluster-integration or ceph-integration packages.
The configuration required for gluster-integration or ceph-integration should be moved to related documents in either gluster or ceph integration packages.
The proposed changes hasn't reached current master (commit 39d2dfe), so I would let it open until that happens. I still see references in the README file:
$ git checkout fix-89
Branch fix-89 set up to track remote branch fix-89 from TimothyAsirJeyasing.
Switched to a new branch 'fix-89'
$ find . -name '*.rst' | xargs egrep '(ceph|gluster)[_-]integration'
$
I noticed that both
tendrl-ceph-integration
andtendrl-gluster-integration
are referenced inREADME
file of node agent, without further explanation what to do with these components (besides default configuration).Based on the already reported issues related to this:
I would assume that content of the README file belongs to installation.rst file (as suggested in #89) and that documentation for overall high level installation of Tendrl belongs to
Tendrl/documentation
repo (as suggested in Tendrl/specifications#25). Another evidence suggesting that this is the case is the fact that no interesting details or further reasoning about integration of node-agent and ceph/gluster-integration components are given (right now, it's just clone a repo and copy default config file).That said, I may be wrong and there may be some reason to reference other components in installation.rst file. If this is the case, this issue is tracking the work on documenting the reasoning of this better, otherwise we could just drop the references to tendrl-ceph-integration and tendrl-gluster-integration from installation.rst file during work on the issues I referenced above and this issue can be closed.
The text was updated successfully, but these errors were encountered: