Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto generated data sets the sighter as none #77

Open
Suchpuns opened this issue Sep 3, 2022 · 0 comments
Open

Auto generated data sets the sighter as none #77

Suchpuns opened this issue Sep 3, 2022 · 0 comments
Assignees
@Suchpuns
Labels
backend involves flask/python/databases bug Something isn't working Tests Catchuping up on missing tests

Comments

@Suchpuns
Copy link
Collaborator

Suchpuns commented Sep 3, 2022

The shots generated from generate_data.py sets the sighter as None (which is the default). This results in some issues such as the Stage.score_as_percent() function returning a zero (because it thinks all the shots are sighters) and the boxplot displaying all stages as having a 0 score.
image
@Suchpuns Suchpuns added bug Something isn't working backend involves flask/python/databases Tests Catchuping up on missing tests labels Sep 3, 2022
@Suchpuns Suchpuns self-assigned this Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Suchpuns Suchpuns

Labels
backend involves flask/python/databases bug Something isn't working Tests Catchuping up on missing tests
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

generated-sighter-update TAS-scorchedshadow/Rifle_Shooting_Major
1 participant
@Suchpuns