Skip to content

Commit

Permalink
Fix setting magik.typing.index*Usages internally in `magik-language…
Browse files Browse the repository at this point in the history
…-server`
  • Loading branch information
StevenLooman committed Mar 15, 2024
1 parent e883481 commit 14e8d61
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
- Add base functionality to apply fixes from magik-lint.
- Add UnsafeEvaluateInvocationCheck to test for unsafe `unsafe_evaluate()` method calls.
- Add SwChar16VectorEvaluateInvocationCheck to test for `sw:char16_vector.evaluate()` method calls.
- Fix setting `magik.typing.index*Usages` internally in `magik-language-server`.

0.9.1 (2024-03-13)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,23 +96,23 @@ public void didChangeConfiguration(final DidChangeConfigurationParams params) {
LOGGER.debug("New settings: {}", settings);
MagikSettings.INSTANCE.setSettings(settings);

// TODO: Move this to MagikAnalysisConfiguration or a separate method?
// Update magik analysis settings.
final boolean magikIndexerIndexGlobalUsages =
Objects.requireNonNullElse(MagikSettings.INSTANCE.getTypingIndexGlobalUsages(), false);
this.analysisConfiguration.setMagikIndexerIndexGlobalUsages(magikIndexerIndexGlobalUsages);

final boolean magikIndexerIndexMethodUsages =
Objects.requireNonNullElse(MagikSettings.INSTANCE.getTypingIndexMethodUsages(), false);
this.analysisConfiguration.setMagikIndexerIndexGlobalUsages(magikIndexerIndexMethodUsages);
this.analysisConfiguration.setMagikIndexerIndexMethodUsages(magikIndexerIndexMethodUsages);

final boolean magikIndexerIndexSlotUsages =
Objects.requireNonNullElse(MagikSettings.INSTANCE.getTypingIndexSlotUsages(), false);
this.analysisConfiguration.setMagikIndexerIndexGlobalUsages(magikIndexerIndexSlotUsages);
this.analysisConfiguration.setMagikIndexerIndexSlotUsages(magikIndexerIndexSlotUsages);

final boolean magikIndexerIndexConditionUsages =
Objects.requireNonNullElse(MagikSettings.INSTANCE.getTypingIndexConditionUsages(), false);
this.analysisConfiguration.setMagikIndexerIndexGlobalUsages(magikIndexerIndexConditionUsages);
this.analysisConfiguration.setMagikIndexerIndexConditionUsages(
magikIndexerIndexConditionUsages);

this.runIndexersInBackground();
}
Expand Down

0 comments on commit 14e8d61

Please sign in to comment.