-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for mercury driver #213
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #213 +/- ##
==========================================
- Coverage 32.67% 31.48% -1.20%
==========================================
Files 85 87 +2
Lines 5800 6026 +226
==========================================
+ Hits 1895 1897 +2
- Misses 3905 4129 +224 ☔ View full report in Codecov by Sentry. |
Please rebase to check if pipeline is now working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, except the minor comments. In general it would also be good to change to str.format.
Thanks for the update. Actually we still should replace the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now, thanks! Great addition to basil
Since quite some lines are added that are not (can not?) be covered by tests, the coverage decreases, but we should ignore that. |
Yeah, this was also my thought. So lets merge ;) |
No description provided.