Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for mercury driver #213

Merged
merged 20 commits into from
May 17, 2024
Merged

Improvements for mercury driver #213

merged 20 commits into from
May 17, 2024

Conversation

SilasM2001
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 43 lines in your changes are missing coverage. Please review.

Project coverage is 31.48%. Comparing base (92d4147) to head (4480251).
Report is 49 commits behind head on master.

Files Patch % Lines
basil/HL/mercury.py 0.00% 43 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
- Coverage   32.67%   31.48%   -1.20%     
==========================================
  Files          85       87       +2     
  Lines        5800     6026     +226     
==========================================
+ Hits         1895     1897       +2     
- Misses       3905     4129     +224     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YannickDieter
Copy link
Contributor

Please rebase to check if pipeline is now working.

Copy link
Contributor

@YannickDieter YannickDieter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except the minor comments. In general it would also be good to change to str.format.

basil/HL/mercury.py Outdated Show resolved Hide resolved
basil/HL/mercury.py Outdated Show resolved Hide resolved
basil/HL/mercury.py Outdated Show resolved Hide resolved
basil/HL/mercury.py Outdated Show resolved Hide resolved
@YannickDieter
Copy link
Contributor

Thanks for the update. Actually we still should replace the prints with proper loggers like it is done for example here

basil/HL/mercury.py Outdated Show resolved Hide resolved
basil/HL/mercury.py Show resolved Hide resolved
Copy link
Contributor

@cbespin cbespin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks! Great addition to basil

@cbespin
Copy link
Contributor

cbespin commented May 17, 2024

Since quite some lines are added that are not (can not?) be covered by tests, the coverage decreases, but we should ignore that.

@YannickDieter
Copy link
Contributor

Yeah, this was also my thought. So lets merge ;)

@YannickDieter YannickDieter merged commit 4bde44a into master May 17, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants