Skip to content

fix(deps): update rust crate toml to 0.7.8 #669

fix(deps): update rust crate toml to 0.7.8

fix(deps): update rust crate toml to 0.7.8 #669

Triggered via push September 9, 2023 05:41
Status Failure
Total duration 1m 23s
Artifacts

clippy.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 1 warning
docs for function which may panic missing `# Panics` section: src/paths.rs#L230
error: docs for function which may panic missing `# Panics` section --> src/paths.rs:230:5 | 230 | pub fn join(&self, rhs: &RelativePath) -> Self { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: first possible panic found here --> src/paths.rs:231:9 | 231 | / Self::try_from( 232 | | rhs.0 233 | | .as_ref() 234 | | .map_or_else(|| self.0.clone(), |rel_path| self.0.join(rel_path)), 235 | | ) 236 | | .expect("a SystemPath rooted in an existing SystemPath is always valid") | |________________________________________________________________________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
docs for function which may panic missing `# Panics` section: src/paths.rs#L171
error: docs for function which may panic missing `# Panics` section --> src/paths.rs:171:5 | 171 | pub fn join(&self, rhs: &RelativePath) -> Self { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: first possible panic found here --> src/paths.rs:172:9 | 172 | / Self::try_from( 173 | | rhs.0 174 | | .as_ref() 175 | | .map_or_else(|| self.0.clone(), |rel_path| self.0.join(rel_path)), 176 | | ) 177 | | .expect("a HoardPath rooted in an existing HoardPath is always valid") | |______________________________________________________________________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
it is more concise to loop over references to containers instead of using explicit iteration methods: src/config/builder/mod.rs#L398
error: it is more concise to loop over references to containers instead of using explicit iteration methods --> src/config/builder/mod.rs:398:31 | 398 | for (_, hoard) in hoards.iter_mut() { | ^^^^^^^^^^^^^^^^^ help: to write this more concisely, try: `&mut *hoards` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_iter_loop
usage of `Iterator::fold` on a type that implements `Try`: src/config/builder/envtrie.rs#L479
error: usage of `Iterator::fold` on a type that implements `Try` --> src/config/builder/envtrie.rs:479:14 | 479 | .fold(Ok(None), |acc, (_, node, path)| match (acc, path) { | ______________^ 480 | | (Err(err), _) | (_, Err(err)) => Err(err), 481 | | (Ok(None), Ok(path)) => Ok(Some((node, path))), 482 | | (Ok(Some((acc, acc_path))), Ok(path)) => match acc.score.cmp(&node.score) { ... | 489 | | }, 490 | | })? | |______________^ help: use `try_fold` instead: `try_fold(None, |acc, (_, node, path)| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
usage of `Iterator::fold` on a type that implements `Try`: src/config/builder/envtrie.rs#L436
error: usage of `Iterator::fold` on a type that implements `Try` --> src/config/builder/envtrie.rs:436:18 | 436 | .fold(Ok(BTreeMap::<EnvironmentName, Node>::new()), |acc, node| { | __________________^ 437 | | // TODO: Use result flattening when stable 438 | | match acc { 439 | | Err(err) => Err(err), ... | 451 | | } 452 | | })?; | |__________________^ help: use `try_fold` instead: `try_fold(BTreeMap::<EnvironmentName, Node>::new(), |acc, node| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
it is more concise to loop over references to containers instead of using explicit iteration methods: src/config/builder/envtrie.rs#L275
error: it is more concise to loop over references to containers instead of using explicit iteration methods --> src/config/builder/envtrie.rs:275:17 | 275 | for list in exclusive_list.iter() { | ^^^^^^^^^^^^^^^^^^^^^ help: to write this more concisely, try: `exclusive_list` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_iter_loop = note: `#[deny(clippy::explicit_iter_loop)]` implied by `#[deny(clippy::pedantic)]`
docs for function which may panic missing `# Panics` section: src/checkers/history/mod.rs#L85
error: docs for function which may panic missing `# Panics` section --> src/checkers/history/mod.rs:85:1 | 85 | pub async fn get_or_generate_uuid() -> Result<Uuid, io::Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: first possible panic found here --> src/checkers/history/mod.rs:118:17 | 118 | / uuid_file 119 | | .parent() 120 | | .expect("uuid file should always have a parent directory"), | |______________________________________________________________________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc note: the lint level is defined here --> src/lib.rs:24:9 | 24 | #![deny(clippy::pedantic)] | ^^^^^^^^^^^^^^^^ = note: `#[deny(clippy::missing_panics_doc)]` implied by `#[deny(clippy::pedantic)]`
usage of `Iterator::fold` on a type that implements `Try`: src/checkers/history/operation/util.rs#L199
error: usage of `Iterator::fold` on a type that implements `Try` --> src/checkers/history/operation/util.rs:199:10 | 199 | .fold(Ok((0, ())), |acc, res2| async move { | __________^ 200 | | let (count, _) = acc?; 201 | | res2.map_err(|err| (count, err))?; 202 | | Ok((count + 1, ())) 203 | | }) | |__________^ help: use `try_fold` instead: `try_fold((0, ()), |acc, res2| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold note: the lint level is defined here --> src/lib.rs:23:9 | 23 | #![deny(clippy::perf)] | ^^^^^^^^^^^^ = note: `#[deny(clippy::manual_try_fold)]` implied by `#[deny(clippy::perf)]`
unnecessary hashes around raw string literal: src/env_vars.rs#L15
error: unnecessary hashes around raw string literal --> src/env_vars.rs:15:16 | 15 | Regex::new(r#"\$\{[^(=|\x{0}|$)]+?}"#).expect("failed to compile regular expression") | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `r"\$\{[^(=|\x{0}|$)]+?}"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes note: the lint level is defined here --> src/lib.rs:21:9 | 21 | #![deny(clippy::style)] | ^^^^^^^^^^^^^ = note: `#[deny(clippy::needless_raw_string_hashes)]` implied by `#[deny(clippy::style)]`
clippy_check
Clippy had exited with the 101 exit code
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/