[Chore] Update NetworkRoot & NetworkProbe to include all new NodeTypes #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the title says, I added all of the specific
Set<Location>'s for node types following the previous pattern, I did it in the order of the NodeType enum as that seemed to be the previous order. I also added all of the getter methods for the new sets.Then I added all of their respective lines to the NetworkProbe network summary as well as adding a new spacer between the item count and node count parts and then a spacer and adding the root power (I can revert those changes if requested)
I haven't actually tested these yet if you would like me too, I just used the node and saw that it didn't show all of the new things so thought I'd make a PR, if it's intentional or not updated yet because you plan on changing on these systems work I can close the PR no problem!