Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper way to add gcode exporter #171

Open
jackcarrozzo opened this issue Jul 13, 2020 · 1 comment
Open

Proper way to add gcode exporter #171

jackcarrozzo opened this issue Jul 13, 2020 · 1 comment

Comments

@jackcarrozzo
Copy link

Hi,

I wrote a gcode exporter class in the style of Exporters/GCode/LinuxCNC.py for my Yasnac controller. I'm running the latest release, 0.6.4. Couple q's:

  • It looks like the gcode exporter used is hard coded to LinuxCNC in Plugins/ToolpathExport.py - I'm happy to make a PR to plumb that through as a configurable option if you let me know how you'd like it to work.
  • Looks like master/0.7 does a lot of reorganization and cleanup - would you like my PR to be against 0.6.4 or should I work on getting master/0.7 to run and make my changes against that?

Thanks for making this stuff! Works extremely well.

@sumpfralle
Copy link
Collaborator

I am glad to hear, you like pycam!

I share your evaluation of the two branches: lots of things changed. Thus I would prefer such a change for master instead of stable/0.6. For your personal use-case it should be easy for you to just switch the hard-coded default locally (in case you want to / need to stick to 0.6).

Feel free to take a quick look and see, how trivial a configurable exporter would be in master.
Otherwise I would take a look at it tomorrow night and try to share thoughts or prepare a bit.

Your contribution is very welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants