From 69604979f3ae070a365b88b918e70e3983cf32ba Mon Sep 17 00:00:00 2001 From: Astitva Aggarwal Date: Wed, 4 Oct 2023 18:10:38 +0530 Subject: [PATCH] minor fixes --- src/discretize.jl | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/src/discretize.jl b/src/discretize.jl index f58f48460..f9fb86d5e 100644 --- a/src/discretize.jl +++ b/src/discretize.jl @@ -645,10 +645,11 @@ function SciMLBase.symbolic_discretize(pde_system::PDESystem, end pinnrep.loss_functions = PINNLossFunctions(bc_loss_functions, pde_loss_functions, - full_likelihood_function, additional_loss, - datafree_pde_loss_functions, - datafree_bc_loss_functions) + full_likelihood_function, additional_loss, + datafree_pde_loss_functions, + datafree_bc_loss_functions) else + function full_loss_function(θ, p) # the aggregation happens on cpu even if the losses are gpu, probably fine since it's only a few of them pde_losses = [pde_loss_function(θ) for pde_loss_function in pde_loss_functions] @@ -719,18 +720,16 @@ function SciMLBase.symbolic_discretize(pde_system::PDESystem, logvector(pinnrep.logger, adaloss.bc_loss_weights, "adaptive_loss/bc_loss_weights", iteration[1]) - end + end end - return full_weighted_loss - end - - pinnrep.loss_functions = PINNLossFunctions(bc_loss_functions, pde_loss_functions, + return full_weighted_loss + end + + pinnrep.loss_functions = PINNLossFunctions(bc_loss_functions, pde_loss_functions, full_loss_function, additional_loss, datafree_pde_loss_functions, datafree_bc_loss_functions) - end end - return pinnrep end