Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROI drawing: can we implement standard shapes, too? #98

Open
sannatitus opened this issue Jun 27, 2023 · 4 comments · May be fixed by #103
Open

ROI drawing: can we implement standard shapes, too? #98

sannatitus opened this issue Jun 27, 2023 · 4 comments · May be fixed by #103
Assignees
Labels

Comments

@sannatitus
Copy link

sannatitus commented Jun 27, 2023

Hey team!

Would it be possible to have three options for drawing ROIs: free hand (what we have already), rectangles and circles?

It's very difficult to draw shapes that are precise enough using the free hand tool. The free hand is super useful for unusual shapes, but it would be much faster to have a rectangle option or circle for things such as the enclosure. At the moment, I'm spending >15 minutes drawing the ROIs for each video (which multiplied by 225 videos, is quite a bit of time!)...

1
2

@sannatitus
Copy link
Author

sannatitus commented Jun 27, 2023

While we're at it, would it also be possible to increase the size of the labelling image? The zoom/pan/drawing works fabulously, but the window itself is a bit small. You can sort of see this in the first attachment^. I'm sure it looks far more proportional on a laptop than my 2ft monitor..

@niksirbi
Copy link
Member

Hey Sanna, thanks for the feedback!

Would it be possible to have three options for drawing ROIs: free hand (what we have already), rectangles and circles?

That's definitely possible. Since most objects will not be perfect circles/rectangle, I assume you still want to be able to manually move points around after you have drawn the rectange/circle?

While we're at it, would it also be possible to increase the size of the labelling image?

I know what you mean, I've tried dong that before and I recall it was not as straightforward as one would think.
But I can have another go at it!

@niksirbi niksirbi self-assigned this Jun 27, 2023
@sannatitus
Copy link
Author

sannatitus commented Jun 27, 2023

Moving points around would be awesome, but having the possibility to have nicer shapes than I can draw freehand would help me out a lot :)

If the labelling image size increase is a hassle, don't worry about it! I think my monitor is just extra large and I can always put my glasses on haha

@niksirbi
Copy link
Member

Alright. I'll take a shot at it and let you know when I have a working prototype.

@niksirbi niksirbi linked a pull request Nov 13, 2023 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants