Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biglots #21

Open
wants to merge 52 commits into
base: master
Choose a base branch
from
Open

Biglots #21

wants to merge 52 commits into from

Conversation

dvosburg
Copy link

No description provided.

@dvosburg dvosburg closed this Dec 21, 2020
@dvosburg dvosburg reopened this Dec 21, 2020
Copy link
Author

@dvosburg dvosburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great


<users>
<user
password="$1$xyz$dCB0XV.AZGZOsJNJwnQVi0"
Copy link
Member

@mbologna mbologna Dec 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you want to commit a hashed password for the two users you created?

Copy link
Member

@aaannz aaannz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is severely modifying base Graphical7 template. I am not sure if you really wanted to submit a PR to master repo or some separate branch but I cannot merge it it current form.

If you really want this to be in master repo, then please create new image name folder for it.

Copy link
Member

@mbologna mbologna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are some things to be addressed:

  • The directory in which this AutoYAST profile lives (please change it to something else than POS_Image-Graphical)
  • The passwords for the two users you created should be specified in the README
  • The README link template points to github.com/dvosburg instead of SUSE/manager-build-profile

@aaannz
Copy link
Member

aaannz commented Jan 14, 2021

I think there are some things to be addressed:
* The directory in which this AutoYAST profile lives (please change it to something else than POS_Image-Graphical)

Note this is not AutoYAST profile, but Kiwi config, agree that this must be something different than POS_Image-Graphical*

@mbologna
Copy link
Member

@dvosburg is this still relevant or can we close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants