Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Country code for China is CN not CH #134

Open
duy64 opened this issue Jul 25, 2024 · 1 comment
Open

Country code for China is CN not CH #134

duy64 opened this issue Jul 25, 2024 · 1 comment

Comments

@duy64
Copy link

duy64 commented Jul 25, 2024

Country code for China is CN not CH
no able to show country flag under CN
also when I added a custom flag icon like Hong Kong and named it as HK it will not show on the game list but only under the game info
theme used is animatics-dx but it also had the same issue with the default theme
https://www.iban.com/country-codes
Screenshot 2024-07-25 103726
Screenshot 2024-07-25 104524
when a game is under China region which is CN it will not show the flag, I had to edit the meta data to CH which is the wrong country code
I also added a Hong Kong flag in the emulationstation folder for the Hong Kong region but it only show the flag on the bottom right corner and not on the actual game list
should I just rename the China flag file to CN then ?
as for the additional country flag like Hong Kong it's still a problem with not showing on the game list
I've tried to change the name of the Chinese flag to cn from ch and updated the game list and now it will only show the flag on the bottom corner and not on the game list
the frontend still thinks chinese is tag as ch and not cn for language and region
perhaps an option to display country flag based on region or language code separately have all country flags available

@Tartifless
Copy link
Member

Hello,
Can you clarify the symptoms or what issue that generates ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants