Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spline Bug in Interpolation Function #1294

Open
nfcarl opened this issue May 24, 2023 · 4 comments
Open

Spline Bug in Interpolation Function #1294

nfcarl opened this issue May 24, 2023 · 4 comments
Labels
beams docs documentation
Milestone

Comments

@nfcarl
Copy link

nfcarl commented May 24, 2023

It appears that .interp() function will not adjust to changes made in spline_opts if resuse_spline=True. In order for spline_opts to work, it needs reuse_spline=False, which is not ideal. This should be fixed so that the parameter will reuse the spline unless there are changes made to the spline options.

Thank you!

@piyanatk
Copy link

@nfcarl Which version of pyuvdata are you seeing this?

@nfcarl
Copy link
Author

nfcarl commented May 25, 2023

The most recent version.

@nfcarl
Copy link
Author

nfcarl commented Jun 8, 2023

To clarify, the main issue is that it should detect a change in spline_opts and perhaps provide an error message, rather than just running the program. If we have reuse_spline=True, then we probably want it to tell you if you are trying to change the spline_opts it won't use the new options.

@nfcarl nfcarl closed this as not planned Won't fix, can't repro, duplicate, stale Jun 8, 2023
@nfcarl nfcarl reopened this Jun 8, 2023
@bhazelton bhazelton added docs documentation and removed bug labels Jul 2, 2024
@bhazelton
Copy link
Member

bhazelton commented Jul 2, 2024

This isn't intrinsically a bug, if the reuse_spline keyword is set, it should reuse the old spline. But the docstrings should be clarified to say that spline_opts is ignored if reuse_spline is True.

@bhazelton bhazelton added this to the Version 3.1 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beams docs documentation
Projects
None yet
Development

No branches or pull requests

3 participants