Reduces JET errors #359
Merged
Reduces JET errors #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR is ready for review, Thank you. |
Krastanov
reviewed
Sep 14, 2024
src/sumtypes.jl
Outdated
Comment on lines
33
to
37
| variant_args = [] | ||
| for t in _types(type) | ||
| push!(variant_args, :(::$t)) | ||
| end | ||
| Expr(:call, _symbol(type), variant_args...) |
There was a problem hiding this comment.
This does not seem to affect the number of JET warnings in my tests. Why is it needed?
src/dense_cliffords.jl
Outdated
| end | ||
| end | ||
| return join([digits_subchars[d+1] for d in reverse(dlist)]) | ||
| end |
There was a problem hiding this comment.
this does not seem to affect the number of jet warnings for me
src/QuantumClifford.jl
Outdated
Comment on lines
766
to
768
| @inline comm!(v, l::PauliOperator, r::Tableau, i::Int) = comm!(v, l, r, i) | ||
| @inline comm!(v, l::Tableau, r::PauliOperator, i::Int) = comm!(v, l, r, i) | ||
| @inline comm!(v, s::Tableau, l::Int, r::Int) = comm!(v, s, l, r) |
There was a problem hiding this comment.
These cause stack overflow errors as they are referring to themselves:
julia> comm!([1,2,3], T"X", P"X", 1)
ERROR: StackOverflowError:
Stacktrace:
[1] comm!(v::Vector{…}, l::QuantumClifford.Tableau{…}, r::PauliOperator{…}, i::Int64) (repeats 79984 times)
@ QuantumClifford ~/Documents/ScratchSpace/quantumjulia/QuantumClifford.jl/src/QuantumClifford.jl:767
Some type information was truncated. Use `show(err)` to see complete types.
Krastanov
added
the
Skip-Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the JET simplification. Let's reduce it a bit further to 15 :)
The
fast_rowandquantum_mallowswere not visible locally, so that's why locally it showed17butnightlyshowed it19.