Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement sm⊗sm, tHadamard*sm, pcT⊗P"X" , pcT*tId1 , P"-Y"*sm and copy(sm) from #260 #345

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Fe-r-oz
Copy link
Contributor

@Fe-r-oz Fe-r-oz commented Aug 22, 2024

Building on #259, breaking down #260 in two smaller PR. Thus, this is the first PR that implements the following:

  • sm⊗sm
  • tHadamard*sm
  • tId1*pcT
  • pcT⊗P"X"
  • copy(sm)
  • P"-Y"*sm

Apologies for the frustrating experience. Hopefully, everything is better now.

P.S. I have also started working on the second half, but before that, we have to introduce embed for AbstractStabilizer and Tableau which is done in (#342). This will be helpful in implementing embed(..., sm).

I am looking for your feedback. Thank you for review.

...
Please address only one topic or issue per pull request! Many small PRs are much easier to review and merge than one large PR.

Before merging, all changes and new functionality should be marked in the CHANGELOG file, but feel free to just leave your CHANGELOG notes in the PR description, to avoid merge conflicts with other requests modifying that file. The maintainer will add these CHANGELOG notes for you if you do so.

Before considering your pull request ready for review and merging make sure that all of the following are completed (please keep the clecklist as part of your PR):

  • The code is properly formatted and commented.
  • Substantial new functionality is documented within the docs.
  • All new functionality is tested.
  • All of the automated tests on github pass.

If possible, keep your git history not too wild (rebase and squash commits, keep commits small and semantically separated) so that review is easier.
...

@Krastanov
Copy link
Member

This would be pretty difficult to review as is. Here are a few things that might help (do not worry about it too much if it is the first time you are experiencing this workflow, it takes a while to get accustomed to it):

I personally would avoid trying to merge the #260 API improvements (what this PR seems to be) until #259 itself is finished (it currently has a buggy implementation).

@Fe-r-oz Fe-r-oz marked this pull request as ready for review August 22, 2024 18:37
@Fe-r-oz Fe-r-oz marked this pull request as draft August 22, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants