Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change github deployment role to pre/post deployment step #45

Open
1 of 4 tasks
thatbudakguy opened this issue Nov 25, 2020 · 0 comments
Open
1 of 4 tasks

Change github deployment role to pre/post deployment step #45

thatbudakguy opened this issue Nov 25, 2020 · 0 comments
Assignees
Labels
chore A task that doesn't require points tracking 🚧 maintenance Upkeep tasks and fixes
Milestone

Comments

@thatbudakguy
Copy link
Contributor

thatbudakguy commented Nov 25, 2020

see for example https://github.com/pulibrary/princeton_ansible/blob/540e2136fdec4becd1336dd1c68ffbf41296de95/playbooks/approvals_production.yml#L12-L21

unfortunately it looks like there's no modules published on ansible galaxy to handle this (we might consider publishing one, actually, if we get it working well). they do have ones for creating/updating github releases, but not deployments.

some digging reveals that pre_tasks and post_tasks are not special at all - they just run arbitrary tasks at the specified time, and will not be run if the playbooks fail. i think the way to approach this is to:

  • consolidate our create/complete/fail deployment tasks into a single github role (along with cloning)
  • use include to pull the tasks from this role into each playbook as pre_tasks and post_tasks
  • make sure the tasks include the special always tag so they run regardless of playbook failure
  • also add a new tag github_deploy (or similar) to the tasks so that we can easily turn off github deploys when running the playbook with --skip-tag=github_deploy or similar. see this article for more info on this approach.
@thatbudakguy thatbudakguy added the chore A task that doesn't require points tracking label Nov 25, 2020
@rlskoeser rlskoeser added the 🚧 maintenance Upkeep tasks and fixes label Mar 23, 2021
@kayiwa kayiwa self-assigned this Aug 2, 2023
@rlskoeser rlskoeser added this to the Fall cleaning milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A task that doesn't require points tracking 🚧 maintenance Upkeep tasks and fixes
Projects
None yet
Development

No branches or pull requests

3 participants