Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpp: check that mesh provided is consistent with problem selected #8

Open
fnrizzi opened this issue May 27, 2021 · 0 comments
Open

Comments

@fnrizzi
Copy link
Member

fnrizzi commented May 27, 2021

Since we have specific problems, we need to add inside the impl classes checks such that when the problems are constucted , the mesh object passed in satisfies the physical bounds for that specific problem

e.g., for the Euler2d:

explicit EigenApp2d(const mesh_t & meshObj, int icId = 1)  
: meshObj_(meshObj), icId_(icId)  {    
 if (probid == 1){ 
   // throw if domain not compatible with 2d Sedov, else throw
 }
else if (probid==2){
   // throw if domain not compatible with 2d Riemann 
}
 ///
}
@fnrizzi fnrizzi changed the title add checks inside impl classes to ensure mesh bounds is consistent check inside impl classes that mesh bounds are consistent with problem selected May 27, 2021
@fnrizzi fnrizzi changed the title check inside impl classes that mesh bounds are consistent with problem selected check that mesh provided is consistent with problem selected Jun 6, 2021
@fnrizzi fnrizzi changed the title check that mesh provided is consistent with problem selected cpp: check that mesh provided is consistent with problem selected Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant