Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing months also changes 'current date' #14

Open
jaredgibb opened this issue Jul 12, 2021 · 4 comments
Open

Changing months also changes 'current date' #14

jaredgibb opened this issue Jul 12, 2021 · 4 comments

Comments

@jaredgibb
Copy link

when moving between months, this also fires the event dateChanged

I notice that dateChanged fires when moving through months. This doesn't make sense as there is also a monthChanged event.

is there a way to isolate dateChanged to only fire when a date has been clicked on?

@PawanKolhe
Copy link
Owner

When the month changes it's updating the currentDate to the 1st day of the month. I'll work on adding an option to disable this behavior so that it only updates when a day is clicked. Will need to create a separate state internally to maintain the selectedDate.

@jaredgibb
Copy link
Author

When the month changes it's updating the currentDate to the 1st day of the month. I'll work on adding an option to disable this behavior so that it only updates when a day is clicked. Will need to create a separate state internally to maintain the selectedDate.

that makes sense! thank you for taking this into consideration!

My use case is that I have an event that fires in my app following a date change. I am using this as a date picker for another calendar that displays events visually by the hour.

when I am browsing for another date, this results in a lot of 'painting' of the screen and extra resources via data pulls and grinding the resulting data.

@jasomdotnet
Copy link

Same problem here.

@Nijas-Phases
Copy link

@PawanKolhe
do you have a solution for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants