Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making ERC404 _storedERC721Ids internal #26

Open
test9955667 opened this issue Feb 16, 2024 · 0 comments
Open

Making ERC404 _storedERC721Ids internal #26

test9955667 opened this issue Feb 16, 2024 · 0 comments

Comments

@test9955667
Copy link

What:
By making _storedERC721Ids in ERC404 internal instead of private, it allows access of the dequeue by 404 extensions without having to edit the core ERC404.sol, and by developers without having to load the state manually. Currently, ERC404 only exposes the length of the dequeue in erc721TokensBankedInQueue().

Why + Example:
An example of an extension that would benefit from this change is a ERC404Viewable.sol. This would expose the queue on the contract api level, lowering the bar for developers who want to access that state. This would make arbitrage of specific 721 ids from the dequeue more accessible for defi power users / devs in general to participate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant