Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chaining save_result does not work for JSON, CSV assets etc #261

Open
bossie opened this issue Feb 20, 2024 · 2 comments
Open

chaining save_result does not work for JSON, CSV assets etc #261

bossie opened this issue Feb 20, 2024 · 2 comments
Labels

Comments

@bossie
Copy link
Collaborator

bossie commented Feb 20, 2024

save_result processes can be chained to output assets in multiple formats e.g.

(data_cube
  .save_result("GTiff")
  .save_result("netCDF")
  .download())

this works for images like GeoTIFF + netCDF but not for e.g. aggregate_spatial output in JSON + CSV.

Can be traced back to aliasing on this line where the last save_result node's format will override previous ones:

data.set_format(format, options)

@bossie bossie added the bug label Feb 20, 2024
bossie added a commit to Open-EO/openeo-geopyspark-driver that referenced this issue Feb 20, 2024
@bossie
Copy link
Collaborator Author

bossie commented Feb 20, 2024

TODO:

@soxofaan
Copy link
Member

FYI (as discussed), this construct

cube
  .save_result("GTiff")
  .save_result("netCDF")

is conceptually shaky: save_result returns a boolean per current spec.
Related ticket for openeo python client to disallow this: Open-EO/openeo-python-client#402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants