Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support load_geojson and load_url #457

Open
soxofaan opened this issue Aug 8, 2023 · 2 comments
Open

Support load_geojson and load_url #457

soxofaan opened this issue Aug 8, 2023 · 2 comments

Comments

@soxofaan
Copy link
Member

soxofaan commented Aug 8, 2023

spin off from #424 to properly track load_geojson/load_url support

(also related to Open-EO/openeo-python-driver#211 )

@soxofaan
Copy link
Member Author

soxofaan commented Aug 9, 2023

some todos for load_url:

if format not in self.list_input_formats():
# TODO: make this an error?
_log.warning(f"Format {format!r} not listed in back-end input formats")
# TODO: Inspect format's gis_data_type to see if we need to load a VectorCube or classic raster DataCube
return VectorCube.load_url(connection=self, url=url, format=format, options=options)

@soxofaan
Copy link
Member Author

soxofaan commented Aug 9, 2023

todos for load_geojson:

  • support client side fetching from URL?
  • unify some parts with DataCube._get_geometry_argument

# TODO: unify with `DataCube._get_geometry_argument`
# TODO #457 also support client side fetching of GeoJSON from URL?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants