Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate duplication between DataCube, VectorCube, ... #278

Open
soxofaan opened this issue Mar 11, 2022 · 3 comments
Open

Eliminate duplication between DataCube, VectorCube, ... #278

soxofaan opened this issue Mar 11, 2022 · 3 comments
Labels
architecture clean up

Comments

@soxofaan
Copy link
Member

soxofaan commented Mar 11, 2022 •
edited
Loading

with addition of MlModel (5d074cb), we have now three classes that duplicate a lot of internals:

  • DataCube
  • VectorCube
  • MlModel

e.g. MlModel is more than 100 LoC, but only 10 is actually MlModel specific, the rest is copied from DataCube. In VectorCube it's even worse

I think these duplicated internals should be moved to a common base
@soxofaan
Copy link
Member Author

related to:

soxofaan added a commit that referenced this issue Mar 11, 2022
@soxofaan
Remove legacy ImageCollection from DataCube class hierarchy (#100/#278
4efab2c 
 related)
soxofaan added a commit that referenced this issue Mar 11, 2022
@soxofaan
fixup! Remove legacy ImageCollection from DataCube class hierarchy (#…
a97c1ac 
…100/#278 related)
This was referenced Mar 14, 2022
Closed
Closed
soxofaan added a commit that referenced this issue Mar 16, 2022
@soxofaan
Issue #278: refactor _pg logic in DataCube/VectorCube/MlModel to co…
ea6b830 
…mmon base class
soxofaan added a commit that referenced this issue Mar 16, 2022
@soxofaan
Simplify doing run_udf on VectorCube
9974c26 
Just use standard method instead of cumbersome PGNode hacking.
Related to #278
soxofaan added a commit that referenced this issue Mar 16, 2022
@soxofaan
Simplify doing run_udf on VectorCube
53c487c 
Just use standard method instead of cumbersome PGNode hacking.
Related to #278
soxofaan added a commit that referenced this issue Mar 16, 2022
@soxofaan
Issue #278: refactor _pg logic in DataCube/VectorCube/MlModel to co…
9fc0565 
…mmon base class
soxofaan added a commit that referenced this issue Mar 16, 2022
@soxofaan
Simplify doing run_udf on VectorCube
70c81fc 
Just use standard method instead of cumbersome PGNode hacking.
Related to #278
soxofaan added a commit that referenced this issue Mar 17, 2022
@soxofaan
Issue #278: refactor _pg logic in DataCube/VectorCube/MlModel to co…
e435d72 
…mmon base class
soxofaan added a commit that referenced this issue Mar 17, 2022
@soxofaan
Simplify doing run_udf on VectorCube
80cec10 
Just use standard method instead of cumbersome PGNode hacking.
Related to #278
soxofaan added a commit that referenced this issue Mar 18, 2022
@soxofaan
Issue #278: make sure inherited methods are shown on DataCube/VectorC…
f2b569b 
…une/... docs
soxofaan added a commit that referenced this issue Mar 18, 2022
@soxofaan
Various #278/#279 documentation finetuning
0ce1691
soxofaan added a commit that referenced this issue Mar 18, 2022
@soxofaan
Issue #278: refactor _pg logic in DataCube/VectorCube/MlModel to co…
5688088 
…mmon base class
soxofaan added a commit that referenced this issue Mar 18, 2022
@soxofaan
Simplify doing run_udf on VectorCube
1927290 
Just use standard method instead of cumbersome PGNode hacking.
Related to #278
soxofaan added a commit that referenced this issue Mar 18, 2022
@soxofaan
Issue #278: make sure inherited methods are shown on DataCube/VectorC…
9c7f4fd 
…une/... docs
soxofaan added a commit that referenced this issue Mar 18, 2022
@soxofaan
Various #278/#279 documentation finetuning
a11e389
@soxofaan
Copy link
Member Author

soxofaan commented Jun 1, 2023

Another use case: with LocalConnection there is also some overlap/duplication with Connection to be eliminated

@soxofaan
Copy link
Member Author

soxofaan commented Aug 9, 2023

also related to #402

@soxofaan soxofaan changed the title Eliminate datacube duplication Eliminate duplication between DataCube, VectorCube, ... Aug 9, 2023
@soxofaan soxofaan mentioned this issue Jul 1, 2024
Open
soxofaan added a commit that referenced this issue Sep 25, 2024
@soxofaan
PR #630 improve save_result handling in VectorCube too (#623, #401, #583
862bfe4 
, #391, #278)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
architecture clean up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@soxofaan