Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aggregate_polygon: coordinate ref system #53

Closed
jdries opened this issue Mar 29, 2019 · 1 comment
Closed

aggregate_polygon: coordinate ref system #53

jdries opened this issue Mar 29, 2019 · 1 comment

Comments

@jdries
Copy link
Contributor

jdries commented Mar 29, 2019

The aggregate_polygons method spec does not mention the handling of the coordinate system of the provided polygons. There are some options:

  • Assume by default that polygon crs matches datacube crs
  • allow specifying a crs explicitly
  • I believe that a geojson featurecollection can have a crs
@m-mohr
Copy link
Member

m-mohr commented Mar 29, 2019 •
edited
Loading

The process allows two data types:

  • GeoJSON: GeoJSON is always WGS84 as specified in their spec (RFC 7946, ch. 4).
  • Vector Data Cube: We haven't really spoken about them yet, but I would imagine that they hold CRS information. That would be in line with how we handle raster data cubes as they also hold information about the CRS/projection.

We may need to clarify the output CRS, but I'd guess it is either restricted by the the output format (if GeoJSON for example) or will be just the CRS of the input polygons. We'll probably tackle this in #2.

@m-mohr m-mohr closed this as completed Mar 29, 2019
@m-mohr m-mohr changed the title aggregate_polygons: coordinate ref system aggregate_polygon: coordinate ref system Mar 29, 2019
This was referenced Apr 19, 2021
Closed
Closed
Closed
soxofaan added a commit to Open-EO/openeo-python-client that referenced this issue Apr 22, 2021
@soxofaan
Issue #204: Raises warning when using a CRS for the geometry of `aggr…
e344c4c 
…egate_spatial` and `mask_polygon`

Harmonize geometry handling in `aggregate_spatial` and `mask_polygon`, including handling of non-standard crs and whitelisting of allowed GeoJSON types
Raises warning when using a CRS for the geometry of `aggregate_spatial` and `mask_polygon`
Also mark this more clearly in the docs

Related: #202, Open-EO/openeo-processes#235, Open-EO/openeo-processes#53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdries @m-mohr