Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UDF support with no runtimes #511

Open
soxofaan opened this issue Sep 12, 2023 · 2 comments
Open

UDF support with no runtimes #511

soxofaan opened this issue Sep 12, 2023 · 2 comments
Labels
Milestone

Comments

@soxofaan
Copy link
Member

Stumbled on this while looking into UDF capability listings in the wild through hub.openeo.org for #510.

EODC backend has "User-defined functions (UDF)" as supported functionalities, but it lists zero UDF runtimes.

This is probably valid spec-wise, but feels against the spirit of this capability listing.

Shouldn't there a minimum of 1 item in the /udf_runtimes listing?

image

@m-mohr
Copy link
Member

m-mohr commented Sep 12, 2023

Yes, indeed. The capabilities listing is currently only based on the list of endpoints as it's a Vue Component that only gets the GET / response as input. Vue Components itself don't do any HTTP requests though. Backends shouldn't expose endpoints that don't provide any value. For lists we could require a minimum number of entries, but for objects we can't do that in OpenAPI yet (I think).

@m-mohr
Copy link
Member

m-mohr commented Sep 30, 2023

I'd love to solve this just by setting the minimum number of entries for objects (JSON Schema: minProperties), but AFAIK OpenAPI only supports this for arrays. So we can only solve this via documentation for now.

Todo: Require at least one entry for /service_types and /udf_runtimes via docs, add it to the schema once we migrate to OpenAPI 3.1 #299

@m-mohr m-mohr added documentation service management udfs and UDF runtime disctovery labels Sep 30, 2023
@m-mohr m-mohr added this to the 1.3.0 milestone Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants