Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[experimental] Get OCF bdevs parameters #32

Open
wants to merge 1 commit into
base: experimental
Choose a base branch
from
Open

[experimental] Get OCF bdevs parameters #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions module/bdev/ocf/utils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,18 @@ static char *cache_modes[ocf_cache_mode_max] = {
[ocf_cache_mode_wo] = "wo",
};

static char *cleaning_policies[ocf_cleaning_max] = {
[ocf_cleaning_nop] = "nop",
[ocf_cleaning_alru] = "alru",
[ocf_cleaning_acp] = "acp",
};

static char *seqcutoff_policies[ocf_seq_cutoff_policy_max] = {
[ocf_seq_cutoff_policy_always] = "always",
[ocf_seq_cutoff_policy_full] = "full",
[ocf_seq_cutoff_policy_never] = "never",
};

ocf_cache_mode_t
ocf_get_cache_mode(const char *cache_mode)
{
Expand Down Expand Up @@ -75,6 +87,24 @@ ocf_get_cache_line_size(ocf_cache_t cache)
return ocf_cache_get_line_size(cache) / KiB;
}

const char *
ocf_get_cleaning_policy_name(ocf_cleaning_t policy)
{
if (policy < ocf_cleaning_max)
return cleaning_policies[policy];
else
return NULL;
}

const char *
ocf_get_seqcutoff_policy_name(ocf_seq_cutoff_policy policy)
{
if (policy < ocf_seq_cutoff_policy_max)
return seqcutoff_policies[policy];
else
return NULL;
}

int
vbdev_ocf_mngt_start(struct vbdev_ocf *vbdev, vbdev_ocf_mngt_fn *path,
vbdev_ocf_mngt_callback cb, void *cb_arg)
Expand Down
6 changes: 6 additions & 0 deletions module/bdev/ocf/utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,12 @@ const char *ocf_get_cache_modename(ocf_cache_mode_t mode);
/* Get cache line size in KiB units */
int ocf_get_cache_line_size(ocf_cache_t cache);

/* Get cleaning policy name */
const char *ocf_get_cleaning_policy_name(ocf_cleaning_t policy);

/* Get sequential cutoff policy name */
const char *ocf_get_seqcutoff_policy_name(ocf_seq_cutoff_policy policy);

/* Initiate management operation
* Receives NULL terminated array of functions (path)
* and callback (cb)
Expand Down
107 changes: 107 additions & 0 deletions module/bdev/ocf/vbdev_ocf_rpc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,11 +304,101 @@ struct bdev_get_bdevs_ctx {
struct spdk_json_write_ctx *w;
};

static void
ocf_json_write_cleaning_params(struct spdk_json_write_ctx *w, ocf_cache_t cache) {
ocf_cleaning_t cleaning_policy;
uint32_t cleaning_wake_up, cleaning_staleness_time,
cleaning_flush_max_buffers, cleaning_activity_threshold;
int rc;

rc = ocf_mngt_cache_cleaning_get_policy(cache, &cleaning_policy);
if (rc)
SPDK_ERRLOG("Could not get OCF cleaning policy: %d\n", rc);
else {
spdk_json_write_named_string(w, "policy", ocf_get_cleaning_policy_name(cleaning_policy));
}

if (cleaning_policy == ocf_cleaning_alru) {
rc = ocf_mngt_cache_cleaning_get_param(cache, ocf_cleaning_alru,
ocf_alru_wake_up_time, &cleaning_wake_up);
if (rc)
SPDK_ERRLOG("Could not get OCF cleaning wake up time: %d\n", rc);
else
spdk_json_write_named_uint32(w, "wake_up", cleaning_wake_up);

rc = ocf_mngt_cache_cleaning_get_param(cache, ocf_cleaning_alru,
ocf_alru_stale_buffer_time, &cleaning_staleness_time);
if (rc)
SPDK_ERRLOG("Could not get OCF cleaning staleness time: %d\n", rc);
else
spdk_json_write_named_uint32(w, "staleness_time", cleaning_staleness_time);

rc = ocf_mngt_cache_cleaning_get_param(cache, ocf_cleaning_alru,
ocf_alru_flush_max_buffers, &cleaning_flush_max_buffers);
if (rc)
SPDK_ERRLOG("Could not get OCF cleaning flush max buffers: %d\n", rc);
else
spdk_json_write_named_uint32(w, "flush_max_buffers", cleaning_flush_max_buffers);

rc = ocf_mngt_cache_cleaning_get_param(cache, ocf_cleaning_alru,
ocf_alru_activity_threshold, &cleaning_activity_threshold);
if (rc)
SPDK_ERRLOG("Could not get OCF cleaning activity threshold: %d\n", rc);
else
spdk_json_write_named_uint32(w, "activity_threshold", cleaning_activity_threshold);

} else if (cleaning_policy == ocf_cleaning_acp) {
rc = ocf_mngt_cache_cleaning_get_param(cache, ocf_cleaning_acp,
ocf_acp_wake_up_time, &cleaning_wake_up);
if (rc)
SPDK_ERRLOG("Could not get OCF cleaning wake up time: %d\n", rc);
else
spdk_json_write_named_uint32(w, "wake_up", cleaning_wake_up);

rc = ocf_mngt_cache_cleaning_get_param(cache, ocf_cleaning_acp,
ocf_acp_flush_max_buffers, &cleaning_flush_max_buffers);
if (rc)
SPDK_ERRLOG("Could not get OCF cleaning flush max buffers: %d\n", rc);
else
spdk_json_write_named_uint32(w, "flush_max_buffers", cleaning_flush_max_buffers);

}
}

static void
ocf_json_write_seqcutoff_params(struct spdk_json_write_ctx *w, ocf_core_t core) {
ocf_seq_cutoff_policy seqcutoff_policy;
uint32_t seqcutoff_threshold, seqcutoff_promotion_count;
int rc;

rc = ocf_mngt_core_get_seq_cutoff_policy(core, &seqcutoff_policy);
if (rc)
SPDK_ERRLOG("Could not get OCF sequential cutoff policy: %d\n", rc);
else
spdk_json_write_named_string(w, "policy", ocf_get_seqcutoff_policy_name(seqcutoff_policy));

rc = ocf_mngt_core_get_seq_cutoff_threshold(core, &seqcutoff_threshold);
if (rc)
SPDK_ERRLOG("Could not get OCF sequential cutoff threshold: %d\n", rc);
else
spdk_json_write_named_uint32(w, "threshold", seqcutoff_threshold);

rc = ocf_mngt_core_get_seq_cutoff_promotion_count(core, &seqcutoff_promotion_count);
if (rc)
SPDK_ERRLOG("Could not get OCF sequential cutoff promotion count: %d\n", rc);
else
spdk_json_write_named_uint32(w, "promotion_count", seqcutoff_promotion_count);
}

static void
bdev_get_bdevs_fn(struct vbdev_ocf *vbdev, void *ctx)
{
struct bdev_get_bdevs_ctx *cctx = ctx;
struct spdk_json_write_ctx *w = cctx->w;
const char *cache_mode_name;
uint32_t cache_line_size;
ocf_cache_t cache;
ocf_core_t core;

if (cctx->name != NULL &&
strcmp(vbdev->name, cctx->name) &&
Expand All @@ -317,18 +407,35 @@ bdev_get_bdevs_fn(struct vbdev_ocf *vbdev, void *ctx)
return;
}

cache = vbdev->ocf_cache;
core = vbdev->ocf_core;
cache_mode_name = ocf_get_cache_modename(ocf_cache_get_mode(cache));
cache_line_size = ocf_get_cache_line_size(cache);

spdk_json_write_object_begin(w);
spdk_json_write_named_string(w, "name", vbdev->name);
spdk_json_write_named_bool(w, "started", vbdev->state.started);

spdk_json_write_named_object_begin(w, "cache");
spdk_json_write_named_string(w, "name", vbdev->cache.name);
spdk_json_write_named_bool(w, "attached", vbdev->cache.attached);
spdk_json_write_named_string(w, "cache_mode", cache_mode_name);
spdk_json_write_named_uint32(w, "cache_line_size", cache_line_size);

spdk_json_write_named_object_begin(w, "cleaning");
ocf_json_write_cleaning_params(w, cache);
spdk_json_write_object_end(w);

spdk_json_write_object_end(w);

spdk_json_write_named_object_begin(w, "core");
spdk_json_write_named_string(w, "name", vbdev->core.name);
spdk_json_write_named_bool(w, "attached", vbdev->core.attached);

spdk_json_write_named_object_begin(w, "sequential_cutoff");
ocf_json_write_seqcutoff_params(w, core);
spdk_json_write_object_end(w);

spdk_json_write_object_end(w);

spdk_json_write_object_end(w);
Expand Down