Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Io forward pt2 #831

Merged
merged 24 commits into from
Sep 20, 2024
Merged

Io forward pt2 #831

merged 24 commits into from
Sep 20, 2024

Conversation

mmichal10
Copy link
Contributor

Requires #829

@pep8speaks
Copy link

pep8speaks commented Sep 18, 2024 •
edited
Loading

Hello @mmichal10! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-09-20 06:08:46 UTC

Deixx
Deixx reviewed Sep 19, 2024
View reviewed changes
inc/ocf_io.h Outdated Show resolved Hide resolved
@mmichal10 mmichal10 force-pushed the io_forward_pt2 branch 3 times, most recently from 7ba69e2 to 960ce49 Compare September 20, 2024 06:08
Deixx
Deixx reviewed Sep 20, 2024
View reviewed changes
src/engine/engine_pt.c Outdated Show resolved Hide resolved
robertbaldyga and others added 24 commits September 20, 2024 13:59
@robertbaldyga @mmichal10
Introduce ocf_forward_write_zeros()
cd544e8 
This is meant to be used in atomic mode to avoid allocating huge buffers
for zeroing data on drive.

Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
@robertbaldyga @mmichal10
composite: Add forward_write_zeros support
17144e5 
Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
@robertbaldyga @mmichal10
Introduce ocf_forward_metadata()
5859e43 
Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
@robertbaldyga @mmichal10
composite: Add forward_metadata support
07abdf5 
Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
@robertbaldyga @mmichal10
Introduce ocf_req_forward_volume_*()
54f75ba 
Those are meant to be used in context where no cache nor queue is
available (typically at very early stage of initialization). We reuse
cache_forward* callback and counter, because they will not be used
in this context anyway.

Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
@robertbaldyga @mmichal10
Introduce ocf_forward_get_data()
6aa141c 
Skip the ocf_io abstraction and get the data directly from the request.

Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
@robertbaldyga @mmichal10
Replace ocf_forward_get_io() with more specific ops
2d303e8 
struct ocf_io is going to be removed soon (consolidated with ocf_request).

Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
@robertbaldyga @mmichal10
composite: Add forward_io_simple support
1f26ceb 
Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
@robertbaldyga @mmichal10
Introduce forward_io_simple
1c2d5bb 
It's intended to be used in a context, where cache is not initialized
and the io_queue is not available yet.

Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
@robertbaldyga @mmichal10
Replace submit with forward in mngt
8347868 
Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
@robertbaldyga @mmichal10
Replace submit with forward in cleaner
322ae26 
Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
@robertbaldyga @mmichal10
Replace submit with forward in standby
29ca8fb 
Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
@robertbaldyga @mmichal10
Replace submit with forward in metadata_io
af3b379 
Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
@robertbaldyga @mmichal10
Replace submit with forward in metadata_raw_atomic
9404716 
Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
@robertbaldyga @mmichal10
Replace submit with forward in ocf_metadata_read_sb()
39d566c 
This one is quite special, because it can be called before cache is
instantiated, which means we can not allocate the request using
ocf_req_new_mngt() due to absence of mngt_queue. For that reason we
simply allocate request using env_zalloc() and then release it with
env_free(). The lifecycle of the request is very straightforward and
the only used fields are forward counter and callback.

Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
@robertbaldyga @mmichal10
Drop support for submit_* ops in backend volumes
7fb6b62 
Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
@robertbaldyga @mmichal10
Bind ocf_io to ocf_request
c5741df 
Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
@robertbaldyga @mmichal10
pyocf: Update tests after the API changes
be0ad8f 
Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
@robertbaldyga @mmichal10
Redirect ocf_volume_submit_* operations to forward
ff5c20b 
Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
@mmichal10
Remove struct ocf_io
f72b922 
Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
@robertbaldyga @mmichal10
example: simple: Update after removing struct ocf_io
6392cce 
Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
@robertbaldyga @mmichal10
pyocf: Update after removing struct ocf_io
9b7f476 
Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
@robertbaldyga @mmichal10
tests: pyocf: Remove legacy submit_* ops implementation from volumes
d8d7504 
Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
@robertbaldyga @mmichal10
Consolidate ocf_request_io and ocf_request - io properties
3fbb757 
Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
@robertbaldyga robertbaldyga merged commit 6907abe into Open-CAS:master Sep 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertbaldyga robertbaldyga robertbaldyga approved these changes

@Deixx Deixx Deixx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmichal10 @pep8speaks @robertbaldyga @Deixx